Rewrite #120
Rewrite #120
Conversation
RealOrangeOne
force-pushed
the
rewrite
branch
3 times, most recently
from
8c5a6d4
to
151bc02
Compare
- remove unnecessary assertion because it's asserted implicitly in the next assertion
|
@RealOrangeOne opened a PR into your |
Signed-off-by: Jason Ma <[email protected]>
- render of `ProgressBarAndroid` changed from `ActivityIndicator` in RN 0.49 back to `AndroidProgressBar` in RN 0.50 Signed-off-by: Jason Ma <[email protected]>
Signed-off-by: Jason Ma <[email protected]>
Signed-off-by: Jason Ma <[email protected]>
Signed-off-by: Jason Ma <[email protected]>
Signed-off-by: Jason Ma <[email protected]>
- Update readme to reference Node 6 support - Update travis to include Node 8.0.0 tests
Rewrite for RN 0.50+
src/haste.js
Outdated
| var files = glob.sync(path.join(PROJECT_NODE_MODULES, '**/*.js')); | ||
|
|
||
| _.forEach(files, function (file) { | ||
| var matches = providesRegex.exec(fs.readFileSync(file).toString()); |
There was a problem hiding this comment.
I ran into an issue here where if the package name ends with .js (example) it will cause the install script to fail. So my workaround was to check if the file is a actual file first. Additionally I changed the wildcard above to */**/*.js.
|
Hi there, what is required to get this over the line? Happy to help if it is of any use |
…nto rewrite # Conflicts: # src/components/View.js # src/propTypes/LayoutPropTypes.js # src/react-native.js
|
I think the core APIs that need to be tested are as follows:
|
|
I believe the way that RN is doing it with jest is a good guideline of how to get these APIs working. |
|
Theoretically, it should be a simple case of stubbing out the native modules related to those APIs, and possibly make them return sane values if required. I'm hoping none of them require a full stub |
|
Whats the ETA for this? |
Enable nodir for glob.sync
There was a problem hiding this comment.
What is the broken test about? "Cannot find module 'react-native/package'" on npm install is the error. Anything to do with this issue by any chance? oblador/react-native-vector-icons#626 (comment)
Edit: I completely misunderstood that error - please see #161 for a proposed fix from me
Lasted Checked Version: 0.42